[4.1] Feature gate HC by cluster feature gate object #318
Conversation
Machine API created its own feature gate object key and diverged from all other components expecting 'cluster' key instead. Renaming the key to 'cluster' to minimize the confusion.
openshift-ci-robot
added
the
size/XS
ingvagabund
changed the title
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/approve |
|
/retest |
openshift-ci-robot
removed
the
do-not-merge/hold
|
@ingvagabund: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr, frobware The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
5 participants
Machine API created its own feature gate object key and diverged from all other
components expecting 'cluster' key instead. Renaming the key to 'cluster'
to minimize the confusion.